Replacement of "table" parameters by their corresponding structure or array of values#8
Open
leniver wants to merge 14 commits intodual-universe:mainfrom
Open
Replacement of "table" parameters by their corresponding structure or array of values#8leniver wants to merge 14 commits intodual-universe:mainfrom
leniver wants to merge 14 commits intodual-universe:mainfrom
Conversation
TODO: Validate that the 'point' parameter is really in world coordinates
Returning vec3 was wrong because it's more than a simple array. Vector3 is defined as an array of numbers
Contributor
|
@NQ-Ligo Any chance of getting this merged anytime soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea behind it is to have a more defined structure so that we can process the data knowing the exact structure of a function return or a parameter.